[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci |
Date: |
Thu, 9 May 2019 08:32:20 +0200 |
User-agent: |
NeoMutt/20180716 |
Hi,
> +static const VirtioPCIDeviceTypeInfo vhost_user_input_pci_info = {
> + .base_name = TYPE_VHOST_USER_INPUT_PCI,
> + .generic_name = "vhost-user-input-pci",
> + .transitional_name = "vhost-user-input-pci-transitional",
> + .non_transitional_name = "vhost-user-input-pci-non-transitional",
virtio-input is virtio 1.0 only, so we don't need these variants.
Incremental fix below, if you ack that I can squash it for the pull req.
Or you send a v3 (in case you have other changes pending).
cheers,
Gerd
--- a/hw/virtio/vhost-user-input-pci.c
+++ b/hw/virtio/vhost-user-input-pci.c
@@ -13,7 +13,7 @@
typedef struct VHostUserInputPCI VHostUserInputPCI;
-#define TYPE_VHOST_USER_INPUT_PCI "vhost-user-input-pci-base"
+#define TYPE_VHOST_USER_INPUT_PCI "vhost-user-input-pci"
#define VHOST_USER_INPUT_PCI(obj) \
OBJECT_CHECK(VHostUserInputPCI, (obj), TYPE_VHOST_USER_INPUT_PCI)
@@ -37,9 +37,7 @@ static void vhost_user_input_pci_instance_init(Object *obj)
static const VirtioPCIDeviceTypeInfo vhost_user_input_pci_info = {
.base_name = TYPE_VHOST_USER_INPUT_PCI,
- .generic_name = "vhost-user-input-pci",
- .transitional_name = "vhost-user-input-pci-transitional",
- .non_transitional_name = "vhost-user-input-pci-non-transitional",
+ .generic_name = TYPE_VHOST_USER_INPUT_PCI,
.parent = TYPE_VIRTIO_INPUT_PCI,
.instance_size = sizeof(VHostUserInputPCI),
.instance_init = vhost_user_input_pci_instance_init,
- [Qemu-devel] [PATCH v2 0/6] Add vhost-user-input, Marc-André Lureau, 2019/05/03
- [Qemu-devel] [PATCH v2 1/6] libvhost-user: fix -Waddress-of-packed-member, Marc-André Lureau, 2019/05/03
- [Qemu-devel] [PATCH v2 2/6] libvhost-user: add PROTOCOL_F_CONFIG if {set, get}_config, Marc-André Lureau, 2019/05/03
- [Qemu-devel] [PATCH v2 3/6] Add vhost-user-backend, Marc-André Lureau, 2019/05/03
- [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci, Marc-André Lureau, 2019/05/03
- Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci, Marc-André Lureau, 2019/05/09
- Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci, Gerd Hoffmann, 2019/05/09
- Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci, Marc-André Lureau, 2019/05/09
- Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci, Marc-André Lureau, 2019/05/09
- Re: [Qemu-devel] [PATCH v2 4/6] Add vhost-user-input-pci, Marc-André Lureau, 2019/05/09
[Qemu-devel] [PATCH v2 5/6] util: simplify unix_listen(), Marc-André Lureau, 2019/05/03
[Qemu-devel] [PATCH v2 6/6] contrib: add vhost-user-input, Marc-André Lureau, 2019/05/03
Re: [Qemu-devel] [PATCH v2 0/6] Add vhost-user-input, Michael S. Tsirkin, 2019/05/09