Re: [Qemu-devel] [PATCH v2 13/29] tcg: Add INDEX_op_dup_mem_vec

[Richard Henderson]

On 5/2/19 6:30 AM, Alex Bennée wrote:
>> +static void do_dup_store(TCGType type, uint32_t dofs, uint32_t oprsz,
>> +                         uint32_t maxsz, TCGv_vec t_vec)
>> +{
>> +    uint32_t i = 0;
>> +
>> +    switch (type) {
>> +    case TCG_TYPE_V256:
>> +        /*
>> +         * Recall that ARM SVE allows vector sizes that are not a
>> +         * power of 2, but always a multiple of 16.  The intent is
>> +         * that e.g. size == 80 would be expanded with 2x32 + 1x16.
>> +         */
> 
> The c&p comment explains the fall-through  although in this case we are
> only mxing and matching V256/V128?

Err.. that's all we ever do.  2x32 + 1x16 + 1x8 is not allowed, and is
validated by check_size_align.


r~