Re: [Qemu-devel] [PULL 0/4] ASAN/UBSAN fixes

[Eric Blake]

On 3/12/19 9:54 AM, Paolo Bonzini wrote:
> On 12/03/19 15:50, Eric Blake wrote:
>> I argued for a better fix for patch 2. Although the changes are minor
>> and therefore probably okay to take the pull request as-is, it also
>> feels like this pull request is needlessly rushed: it is less than 30
>> minutes after the patch was first posted to the list.  And since they
>> ARE bug-fixes, the content in these patches are appropriate during soft
>> freeze, rather than having to get in today.
> 
> True, on the other hand the failures are in master and they are causing
> Patch to mark all series as testing failures (asan failures are not yet
> sent to the mailing list).

Okay, that gives some more context (making patchew more reliable on
other patches is indeed a reasonable reason for a quick fix). (And it
makes a change for you to get a complaint about a fast patch, after the
recent complaints you've had in the other direction about why a small
patch doesn't go fast :)

> 
> I'm sorry for not noticing your answer to patch 2.

Such is life when mails cross. No hard feelings.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature