Re: [Qemu-devel] [PULL 0/4] ASAN/UBSAN fixes

[Eric Blake]

On 3/12/19 9:36 AM, Paolo Bonzini wrote:
> The following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5:
> 
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into 
> staging (2019-03-11 18:26:37 +0000)
> 
> are available in the Git repository at:
> 
>   git://github.com/bonzini/qemu.git tags/for-upstream
> 
> for you to fetch changes up to 1e25879e6f832373775492c11c648ab2fff69bd5:
> 
>   test-migration: fix memory leak (2019-03-12 15:18:40 +0100)
> 
> ----------------------------------------------------------------
> * ASAN fixes
> 
> ----------------------------------------------------------------
> Paolo Bonzini (4):
>       test-char: fix undefined behavior
>       test-bdrv-graph-mod: fix Error leak

I argued for a better fix for patch 2. Although the changes are minor
and therefore probably okay to take the pull request as-is, it also
feels like this pull request is needlessly rushed: it is less than 30
minutes after the patch was first posted to the list.  And since they
ARE bug-fixes, the content in these patches are appropriate during soft
freeze, rather than having to get in today.

Oh well, I'm fine whether this goes in as-is (and we do a followup patch
to use error_free_or_abort) or if we get a v2 on this series.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature