Re: [Qemu-devel] [PATCH v5-resend 2/2] mips_fulong2e: Add on-board graphics chip

[BALATON Zoltan]

On Thu, 7 Mar 2019, Philippe Mathieu-Daudé wrote:
> On 3/6/19 9:05 PM, BALATON Zoltan wrote:
> > Add (partial) emulation of the on-board GPU of the machine. This
> > allows the PMON2000 firmware to run and should also work with Linux
> > console but probably not with X yet.
> >
> > Signed-off-by: BALATON Zoltan <address@hidden>
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
> Mojibaked again :(

Sorry. Looks like my setup just can't handle your encoding. Maybe I need 
an additional header to specify content encoding? Do you have a git config 
to tell format-patch to generate that? Or have a way for maintainers to 
correct this on merging automatically?

> Aleksandar, if you take this series, do you mind fixing with:

I think it should go via Gerd's tree together with the other patch.

Regards,
BALATON Zoltan

> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
> Thanks!
>
> Phil.
>
> > Reviewed-by: Aleksandar Markovic <address@hidden>
> > ---
> >  hw/mips/mips_fulong2e.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
> > index fbbc543eed..f877693766 100644
> > --- a/hw/mips/mips_fulong2e.c
> > +++ b/hw/mips/mips_fulong2e.c
> > @@ -287,6 +287,7 @@ static void mips_fulong2e_init(MachineState *machine)
> >      I2CBus *smbus;
> >      MIPSCPU *cpu;
> >      CPUMIPSState *env;
> > +    DeviceState *dev;
> >
> >      /* init CPUs */
> >      cpu = MIPS_CPU(cpu_create(machine->cpu_type));
> > @@ -347,6 +348,11 @@ static void mips_fulong2e_init(MachineState *machine)
> >      vt82c686b_southbridge_init(pci_bus, FULONG2E_VIA_SLOT, env->irq[5],
> >                                 &smbus, &isa_bus);
> >
> > +    /* GPU */
> > +    dev = DEVICE(pci_create(pci_bus, -1, "ati-vga"));
> > +    qdev_prop_set_uint16(dev, "x-device-id", 0x5159);
> > +    qdev_init_nofail(dev);
> > +
> >      /* Populate SPD eeprom data */
> >      spd_data = spd_data_generate(DDR, ram_size, &err);
> >      if (err) {