Re: [Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding

[Gerd Hoffmann]

On Sun, Mar 03, 2019 at 11:44:30AM +0100, Samuel Thibault wrote:
> This uses iconv to convert glyphs from the specified VGA font encoding to
> unicode, and makes use of cchar_t instead of chtype when using ncursesw,
> which allows to store all wide char as well as the WACS values.
> 
> Signed-off-by: Samuel Thibault <address@hidden>
> Cc: Eddie Kohler <address@hidden>

So the difference to the patch from Eddie is that charset
is configurable instead of being hard-coded to CP437?

> +# @charset:       Font charset used by guest (default: CP437).

> @@ -1139,7 +1140,8 @@
>    'base'    : { 'type'           : 'DisplayType',
>                  '*full-screen'   : 'bool',
>                  '*window-close'  : 'bool',
> -                '*gl'            : 'DisplayGLMode' },
> +                '*gl'            : 'DisplayGLMode',
> +                '*charset'       : 'str' },

No.  Please add a new DisplayCurses struct for the charset option.  It
will only be used by the curses UI and it is highly unlikely that this
will ever change as only curses needs this (the graphical UIs will just
use whatever font the guest loaded into the vga).

cheers,
  Gerd