Re: [Qemu-devel] [PATCH 1/5] roms: add the edk2 project as a git submodule

[Laszlo Ersek]

On 01/21/19 20:45, Philippe Mathieu-Daudé wrote:
> On 1/21/19 7:41 PM, Laszlo Ersek wrote:
>> On 01/21/19 12:25, Philippe Mathieu-Daudé wrote:

>>> I suggest the following change, Daniel/Alex what do you think?
>>>
>>> -- >8 --
>>> diff --git a/scripts/git-submodule.sh b/scripts/git-submodule.sh
>>> index 98ca0f2737..5441fe3385 100755
>>> --- a/scripts/git-submodule.sh
>>> +++ b/scripts/git-submodule.sh
>>> @@ -71,7 +71,7 @@ update)
>>>          exit 0
>>>      fi
>>>
>>> -    $GIT submodule update --init $modules 1>/dev/null
>>> +    $GIT submodule update --init --recursive $modules 1>/dev/null
>>>      test $? -ne 0 && error "failed to update modules"
>>>
>>>      $GIT submodule status $modules > "${substat}"
>>> ---
>>
>> This shouldn't make a difference, as edk2 is not a nested submodule of
>> another submodule; it is a submodule directly under the main
>> superproject, i.e. QEMU.
> 
> OK (as long as we don't want to build OVMF within QEMU to run QEMU tests).

I think if / whenever we bundle OVMF binaries with QEMU, there'll be a
two step process (like with other roms); maintainers will (re)build the
binaries and commit/merge them, and tests will use the bundled binaries
as they are.

Thanks
Laszlo