[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus'
From: |
Paul Durrant |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy |
Date: |
Wed, 28 Nov 2018 17:04:00 +0000 |
> -----Original Message-----
> From: Eric Blake [mailto:address@hidden
> Sent: 28 November 2018 17:01
> To: Paul Durrant <address@hidden>; 'Kevin Wolf'
> <address@hidden>
> Cc: Stefano Stabellini <address@hidden>; Eduardo Habkost
> <address@hidden>; address@hidden; Michael S. Tsirkin
> <address@hidden>; address@hidden; Paolo Bonzini
> <address@hidden>; Anthony Perard <address@hidden>; xen-
> address@hidden; Richard Henderson <address@hidden>
> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new
> 'XenBus' and 'XenDevice' object hierarchy
>
> On 11/28/18 10:26 AM, Paul Durrant wrote:
>
> >>> +++ b/hw/xen/xen-bus.c
> >>> @@ -0,0 +1,125 @@
> >>> +/*
> >>> + * Copyright (c) Citrix Systems Inc.
> >>> + * All rights reserved.
> >>> + */
> >>
> >> This doesn't look very compatible with the GPL. In fact it might even
> >> make it illegal for the QEMU project to distribute this code. :-)
> >>
> >> Other files you add throughout the series seem to have the same
> problem.
> >>
> >
> > I was working on the assumption that a lack of explicit license meant
> that the overall project license as described in item 2 in LICENSE. Did I
> misinterpret that text?
>
> No, but you missed the fact that "All rights reserved" is an explicit
> license (or rather, an explicit anti-license that states you are not
> granting rights that the GPL would normally grant), and an implicit
> license does not apply when an explicit (anti-)license is present.
>
> What's more, relying on implicit licenses is prone to misinterpretation,
> so even though the overall project documentation tries to cover what
> will happen, it's much nicer if you DO use an explicit license mention
> in your file so that we don't HAVE to rely on the implicit license.
>
> Yes, the phrase "All rights reserved" exists in several existing files:
>
> $ git grep -il 'all rights reserved' |wc
> 138 138 3557
>
> but we should be striving to clean those up, not adding to the mess.
Ok. I'll send a v2 with the "All rights reserved" removed from and a GPL
statement added to all the new files.
Paul
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, (continued)
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Kevin Wolf, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Stefano Stabellini, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Kevin Wolf, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Kevin Wolf, 2018/11/29
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Eric Blake, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy,
Paul Durrant <=
Re: [Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Anthony PERARD, 2018/11/28
[Qemu-devel] [PATCH 07/18] xen: add event channel interface for XenDevice-s, Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-qdisk.c, Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 03/18] xen: introduce 'xen-qdisk', Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 01/18] xen: re-name XenDevice to XenLegacyDevice..., Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 04/18] xen: create xenstore areas for XenDevice-s, Paul Durrant, 2018/11/21