[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevic
From: |
Paul Durrant |
Subject: |
Re: [Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy |
Date: |
Wed, 28 Nov 2018 17:17:10 +0000 |
> -----Original Message-----
> From: Anthony PERARD [mailto:address@hidden
> Sent: 28 November 2018 17:10
> To: Paul Durrant <address@hidden>
> Cc: address@hidden; address@hidden; xen-
> address@hidden; Stefano Stabellini <address@hidden>;
> Michael S. Tsirkin <address@hidden>; Marcel Apfelbaum
> <address@hidden>; Paolo Bonzini <address@hidden>; Richard
> Henderson <address@hidden>; Eduardo Habkost <address@hidden>
> Subject: Re: [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice'
> object hierarchy
>
> On Wed, Nov 21, 2018 at 03:11:55PM +0000, Paul Durrant wrote:
> > diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> > new file mode 100644
> > index 0000000000..dede2d914a
> > --- /dev/null
> > +++ b/hw/xen/xen-bus.c
> > @@ -0,0 +1,125 @@
> > +/*
> > + * Copyright (c) Citrix Systems Inc.
> > + * All rights reserved.
>
> You probably should include:
> This work is licensed under the terms of the GNU GPL, version 2 or
> later.
> See the COPYING file in the top-level directory.
>
> As this seems to be a boilerplate used in recent new files, there are
> other similair boilerplates.
>
> Also, I think the copyright line should include a year.
Ok.
>
> > +void xen_bus_init(void)
> > +{
> > + DeviceState *dev = qdev_create(NULL, TYPE_XEN_BRIDGE);
> > +
> > + qbus_create(TYPE_XEN_BUS, dev, NULL);
> > + qdev_init_nofail(dev);
>
> Will we need a hotplug handler for this bus, like it is done with
> TYPE_XENSYSBUS?
I didn't seem to need one even doing 'xl block-attach' after the VM had booted.
I'm really not sure what that does.
Paul
>
>
> The rest looks good,
> Thanks,
>
> --
> Anthony PERARD
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, (continued)
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Stefano Stabellini, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Kevin Wolf, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Kevin Wolf, 2018/11/29
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Eric Blake, 2018/11/28
- Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Paul Durrant, 2018/11/28
Re: [Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy, Anthony PERARD, 2018/11/28
[Qemu-devel] [PATCH 07/18] xen: add event channel interface for XenDevice-s, Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-qdisk.c, Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 03/18] xen: introduce 'xen-qdisk', Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 01/18] xen: re-name XenDevice to XenLegacyDevice..., Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 04/18] xen: create xenstore areas for XenDevice-s, Paul Durrant, 2018/11/21
[Qemu-devel] [PATCH 05/18] xen: add xenstore watcher infratructure, Paul Durrant, 2018/11/21