qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-3.2 v4 09/28] tests: qdev_prop_check_globals


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH for-3.2 v4 09/28] tests: qdev_prop_check_globals() doesn't return "all_used"
Date: Tue, 27 Nov 2018 11:40:37 -0200
User-agent: Mutt/1.9.2 (2017-12-15)

On Tue, Nov 27, 2018 at 01:27:42PM +0400, Marc-André Lureau wrote:
> Instead, it returns 1 if an error was detected, which is the case for:
> 
> /qdev/properties/dynamic/global/subprocess:
> warning: global dynamic-prop-type-bad.prop3 has invalid class name
> warning: global nohotplug-type.prop5=105 not used
> warning: global nondevice-type.prop6 has invalid class name
> 
> Clarify the function return value.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>

Reviewed-by: Eduardo Habkost <address@hidden>

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]