[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-3.2 v4 01/28] target/xtensa: gdbstub fix registe
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH for-3.2 v4 01/28] target/xtensa: gdbstub fix register counting |
Date: |
Tue, 27 Nov 2018 13:27:34 +0400 |
From: Max Filippov <address@hidden>
In order to communicate correctly with gdb xtensa gdbstub must provide
expected number of registers in 'g' packet response. xtensa-elf-gdb
expects both nonprivileged and privileged registers. xtensa-linux-gdb
only expects nonprivileged registers. gdb only counts one contiguous
stretch of registers, do the same for the core registers in the
xtensa_count_regs.
With this change qemu-system-xtensa is able to communicate with all
xtensa-elf-gdb versions (versions prior to 8.2 require overlay fixup),
and qemu-xtensa is able to communicate with all xtensa-linux-gdb
versions, except 8.2.
Signed-off-by: Max Filippov <address@hidden>
---
target/xtensa/gdbstub.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/target/xtensa/gdbstub.c b/target/xtensa/gdbstub.c
index c9450914c7..d43bb190c6 100644
--- a/target/xtensa/gdbstub.c
+++ b/target/xtensa/gdbstub.c
@@ -45,15 +45,20 @@ void xtensa_count_regs(const XtensaConfig *config,
unsigned *n_regs, unsigned *n_core_regs)
{
unsigned i;
+ bool count_core_regs = true;
for (i = 0; config->gdb_regmap.reg[i].targno >= 0; ++i) {
if (config->gdb_regmap.reg[i].type != xtRegisterTypeTieState &&
config->gdb_regmap.reg[i].type != xtRegisterTypeMapped &&
config->gdb_regmap.reg[i].type != xtRegisterTypeUnmapped) {
++*n_regs;
- if ((config->gdb_regmap.reg[i].flags &
- XTENSA_REGISTER_FLAGS_PRIVILEGED) == 0) {
- ++*n_core_regs;
+ if (count_core_regs) {
+ if ((config->gdb_regmap.reg[i].flags &
+ XTENSA_REGISTER_FLAGS_PRIVILEGED) == 0) {
+ ++*n_core_regs;
+ } else {
+ count_core_regs = false;
+ }
}
}
}
--
2.20.0.rc1
- [Qemu-devel] [PATCH for-3.2 v4 00/28] Generalize machine compatibility properties, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 01/28] target/xtensa: gdbstub fix register counting,
Marc-André Lureau <=
- [Qemu-devel] [PATCH for-3.2 v4 02/28] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 03/28] target/xtensa: xtfpga: provide default memory sizes, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 04/28] MAINTAINERS: add missing xtensa patterns, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 05/28] 9p: fix QEMU crash when renaming files, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 06/28] MAINTAINERS: Assign some more files in the hw/arm/ directory, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 07/28] MAINTAINERS: Add an ARM SMMU section, Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 09/28] tests: qdev_prop_check_globals() doesn't return "all_used", Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 08/28] net: cadence_gem: Remove incorrect assert(), Marc-André Lureau, 2018/11/27
- [Qemu-devel] [PATCH for-3.2 v4 10/28] qom: make interface types abstract, Marc-André Lureau, 2018/11/27