[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rou
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rounding |
Date: |
Mon, 20 Aug 2018 12:35:34 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16
double-rounding
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
776a29ed02 target/arm: Use the float-to-int-scale softfloat routines
c08c4abc59 target/arm: Use the int-to-float-scale softfloat routines
71c42653c5 softfloat: Add scaling float-to-int routines
040490a28a softfloat: Add scaling int-to-float routines
=== OUTPUT BEGIN ===
Checking PATCH 1/4: softfloat: Add scaling int-to-float routines...
Checking PATCH 2/4: softfloat: Add scaling float-to-int routines...
Checking PATCH 3/4: target/arm: Use the int-to-float-scale softfloat routines...
Checking PATCH 4/4: target/arm: Use the float-to-int-scale softfloat routines...
ERROR: space prohibited before that close parenthesis ')'
#58: FILE: target/arm/helper.c:11585:
+ get_float_rounding_mode(fpst), )
ERROR: space prohibited before that close parenthesis ')'
#64: FILE: target/arm/helper.c:11590:
+ get_float_rounding_mode(fpst), )
total: 2 errors, 0 warnings, 142 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rounding, Richard Henderson, 2018/08/13
- [Qemu-devel] [PATCH 1/4] softfloat: Add scaling int-to-float routines, Richard Henderson, 2018/08/13
- [Qemu-devel] [PATCH 3/4] target/arm: Use the int-to-float-scale softfloat routines, Richard Henderson, 2018/08/13
- [Qemu-devel] [PATCH 4/4] target/arm: Use the float-to-int-scale softfloat routines, Richard Henderson, 2018/08/13
- [Qemu-devel] [PATCH 2/4] softfloat: Add scaling float-to-int routines, Richard Henderson, 2018/08/13
- Re: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rounding, Alex Bennée, 2018/08/14
- Re: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rounding, no-reply, 2018/08/16
- Re: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rounding, Peter Maydell, 2018/08/20
- Re: [Qemu-devel] [PATCH 0/4] target/arm: Fix int64_to_float16 double-rounding,
no-reply <=