qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 52/56] json: Eliminate lexer state IN_WHITESPACE


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 52/56] json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP
Date: Thu, 16 Aug 2018 08:51:04 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 08/08/2018 07:03 AM, Markus Armbruster wrote:
Bonus: static json_lexer[] loses its unused elements.  It shrinks from
8KiB to 4.75KiB for me.

Signed-off-by: Markus Armbruster <address@hidden>
---
  include/qapi/qmp/json-lexer.h |  1 -
  qobject/json-lexer.c          | 30 +++++++++---------------------
  2 files changed, 9 insertions(+), 22 deletions(-)


Impacted when rebasing atop my earlier ideas for compressing IN_INTERPOL initialization, but overall:

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]