Re: [Qemu-devel] [PATCH 20/56] check-qjson: Document we expect invalid UTF-8 to be rejected

[Eric Blake]

On 08/08/2018 07:02 AM, Markus Armbruster wrote:
> The JSON parser rejects some invalid sequences, but accepts others
> without correcting the problem.
>
> We should either reject all invalid sequences, or minimize overlong
> sequences and replace all other invalid sequences by a suitable
> replacement character.  A common choice for replacement is U+FFFD.
>
> I'm going to implement the former.  Update the comments in
> utf8_string() to expect this.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   tests/check-qjson.c | 151 +++++++++++++++++++++-----------------------
>   1 file changed, 71 insertions(+), 80 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org