[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/7] migrate: Fix cancelling state warning
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 2/7] migrate: Fix cancelling state warning |
Date: |
Tue, 24 Jul 2018 19:34:49 +0100 |
From: "Dr. David Alan Gilbert" <address@hidden>
We've been getting the warning:
migration_iteration_finish: Unknown ending state 2
on a cancel.
I think that's originally due to 39b9e17905c; although
I've only seen the warning, I think that in some cases
that we could find the VM stays paused after a cancel where
it should restart.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/migration.c b/migration/migration.c
index 8d56d56930..db6bde7453 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2877,6 +2877,7 @@ static void migration_iteration_finish(MigrationState *s)
/* Fallthrough */
case MIGRATION_STATUS_FAILED:
case MIGRATION_STATUS_CANCELLED:
+ case MIGRATION_STATUS_CANCELLING:
if (s->vm_was_running) {
vm_start();
} else {
--
2.17.1
- [Qemu-devel] [PULL 0/7] migration queue for 3.0, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 1/7] migration: fix potential overflow in multifd send, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 2/7] migrate: Fix cancelling state warning,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 4/7] migration: update recv bitmap only on dest vm, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 3/7] audio/hda: Fix migration, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 5/7] migration: disallow recovery for release-ram, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 6/7] tests: only update last_byte when at the edge, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 7/7] migration: fix duplicate initialization for expected_downtime and cleanup_bh, Dr. David Alan Gilbert (git), 2018/07/24
- Re: [Qemu-devel] [PULL 0/7] migration queue for 3.0, Peter Maydell, 2018/07/24