[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/7] audio/hda: Fix migration
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 3/7] audio/hda: Fix migration |
Date: |
Tue, 24 Jul 2018 19:34:50 +0100 |
From: "Dr. David Alan Gilbert" <address@hidden>
Fix outgoing migration which was crashing in
vmstate_hda_audio_stream_buf_needed, I think the problem
is that we have room for upto 4 streams in the array but only
use 2, when we come to try and save the state of the unused
streams we hit st->state == NULL.
Fixes: 280c1e1cdb24d80ecdfc
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
hw/audio/hda-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c
index 2b58c3505b..617a1c1016 100644
--- a/hw/audio/hda-codec.c
+++ b/hw/audio/hda-codec.c
@@ -786,7 +786,7 @@ static void hda_audio_reset(DeviceState *dev)
static bool vmstate_hda_audio_stream_buf_needed(void *opaque)
{
HDAAudioStream *st = opaque;
- return st->state->use_timer;
+ return st->state && st->state->use_timer;
}
static const VMStateDescription vmstate_hda_audio_stream_buf = {
--
2.17.1
- [Qemu-devel] [PULL 0/7] migration queue for 3.0, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 1/7] migration: fix potential overflow in multifd send, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 2/7] migrate: Fix cancelling state warning, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 4/7] migration: update recv bitmap only on dest vm, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 3/7] audio/hda: Fix migration,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 5/7] migration: disallow recovery for release-ram, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 6/7] tests: only update last_byte when at the edge, Dr. David Alan Gilbert (git), 2018/07/24
- [Qemu-devel] [PULL 7/7] migration: fix duplicate initialization for expected_downtime and cleanup_bh, Dr. David Alan Gilbert (git), 2018/07/24
- Re: [Qemu-devel] [PULL 0/7] migration queue for 3.0, Peter Maydell, 2018/07/24