Re: [Qemu-devel] [PATCH v3 05/40] target/mips: Add nanoMIPS decoding and extraction utilities

[Aleksandar Markovic]

> From: Richard Henderson <address@hidden>
> Sent: Thursday, July 19, 2018 6:57 PM
>
> I think it's worth spending one line to document the pseudocode function from
> which each of these come.  E.g.
>
> /* Implement nanoMIPS pseudocode decode_gpr(encoded_gpr, 'gpr4.zero').  */
>
> Which is certainly more accurate than the comment that is there currently.
>
> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~

Hello, Richard

The comments will be fixed in v4. Also, the fourth decode_gpr_XXX function will 
be moved to this patch (from one of remaining patches with decoding logic). 
These functions will be all marked inline. This also means that the compiler 
will not complain about "unused functions".

Aleksandar