[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] monitor: enable OOB by default
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] monitor: enable OOB by default |
Date: |
Wed, 27 Jun 2018 10:41:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Markus Armbruster <address@hidden> writes:
> Markus Armbruster <address@hidden> writes:
>
>> I fooled around a bit, and I think there are a few lose ends.
> [...]
>> Talking to a QMP monitor that supports OOB:
>>
>> $ socat UNIX:test-qmp READLINE,history=$HOME/.qmp_history,prompt='QMP> '
>> {"QMP": {"version": {"qemu": {"micro": 50, "minor": 12, "major": 2},
>> "package": "v2.12.0-1703-gb909799463"}, "capabilities": ["oob"]}}
>> QMP> { "execute": "qmp_capabilities", "arguments": { "oob": true } }
>> {"error": {"class": "GenericError", "desc": "Parameter 'oob' is
>> unexpected"}}
>> QMP> { "execute": "qmp_capabilities", "arguments": { "enable": ["oob"] }
>> }
>> {"return": {}}
>> QMP> { "execute": "query-qmp-schema" }
>> {"error": {"class": "GenericError", "desc": "Out-Of-Band capability
>> requires that every command contains an 'id' field"}}
>>
>> Why does every command require 'id'?
>
> I found one reason: event COMMAND_DROPPED wants it. Any other reason?
>
> [...]
Apropos COMMAND_DROPPED: we send an event rather than an error response
because we may send it out-of-order. Makes sense.
However, broadcasting it to all monitors doesn't make sense. We could
use a way to send an event to just one monitor.
Another use for that might be QMP "deprecated" notifications, because
those also can't be error responses, and also only make sense for the
client that caused them.
- Re: [Qemu-devel] [PATCH v5 3/7] monitor: flush qmp responses when CLOSED, (continued)
[Qemu-devel] [PATCH v5 4/7] tests: iotests: drop some stderr line, Peter Xu, 2018/06/20
[Qemu-devel] [PATCH v5 5/7] docs: mention shared state protect for OOB, Peter Xu, 2018/06/20
[Qemu-devel] [PATCH v5 6/7] monitor: remove "x-oob", turn oob on by default, Peter Xu, 2018/06/20
[Qemu-devel] [PATCH v5 7/7] Revert "tests: Add parameter to qtest_init_without_qmp_handshake", Peter Xu, 2018/06/20
[Qemu-devel] (no subject), Markus Armbruster, 2018/06/26
- Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default,
Markus Armbruster <=
- Re: [Qemu-devel] monitor: enable OOB by default, Daniel P . Berrangé, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Peter Xu, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Eric Blake, 2018/06/27
- Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/28
- Re: [Qemu-devel] monitor: enable OOB by default, Peter Xu, 2018/06/29
Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/28
Re: [Qemu-devel] monitor: enable OOB by default, Eric Blake, 2018/06/28
Re: [Qemu-devel] monitor: enable OOB by default, Peter Xu, 2018/06/29
Re: [Qemu-devel] monitor: enable OOB by default, Markus Armbruster, 2018/06/27