[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 16/35] target/arm: Implement SVE floating-poi
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v5 16/35] target/arm: Implement SVE floating-point compare vectors |
Date: |
Tue, 26 Jun 2018 09:41:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/25/2018 10:20 AM, Peter Maydell wrote:
>> +#define DO_FCMGE(TYPE, X, Y, ST) TYPE##_compare(Y, X, ST) <= 0
>
> I was expecting the RHS of this to be TYPE##_le(Y, X, ST).
> This prompted me to notice that softfloat has as well as
> the generic 'compare' routines also specialized _le/lt/unordered
> etc functions for float64 and float32 but not float16, which is
> a bit inconsistent...
Yes. I have a mild preference to using floatN_compare everywhere and removing
the other functions entirely. But that's a medium sized job across multiple
targets. I also agree that in the meantime the inconsistency is surprising.
r~
- Re: [Qemu-devel] [PATCH v5 13/35] target/arm: Implement SVE gather loads, (continued)
- [Qemu-devel] [PATCH v5 11/35] target/arm: Implement SVE scatter stores, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 15/35] target/arm: Implement SVE scatter store vector immediate, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 14/35] target/arm: Implement SVE first-fault gather loads, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 16/35] target/arm: Implement SVE floating-point compare vectors, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 17/35] target/arm: Implement SVE floating-point arithmetic with immediate, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 18/35] target/arm: Implement SVE Floating Point Multiply Indexed Group, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 20/35] target/arm: Implement SVE Floating Point Unary Operations - Unpredicated Group, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 19/35] target/arm: Implement SVE FP Fast Reduction Group, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 22/35] target/arm: Implement SVE floating-point trig multiply-add coefficient, Richard Henderson, 2018/06/20