[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 17/35] target/arm: Implement SVE floating-poi
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5 17/35] target/arm: Implement SVE floating-point arithmetic with immediate |
Date: |
Mon, 25 Jun 2018 18:27:56 +0100 |
On 21 June 2018 at 02:53, Richard Henderson
<address@hidden> wrote:
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/arm/helper-sve.h | 56 ++++++++++++++++++++++++++++
> target/arm/sve_helper.c | 69 +++++++++++++++++++++++++++++++++++
> target/arm/translate-sve.c | 75 ++++++++++++++++++++++++++++++++++++++
> target/arm/sve.decode | 14 +++++++
> 4 files changed, 214 insertions(+)
> +
> +#define float16_two make_float16(0x4000)
> +#define float32_two make_float32(0x40000000)
> +#define float64_two make_float64(0x4000000000000000ULL)
We seem to have these already in include/fpu/softfloat.h.
> +DO_FP_IMM(FADD, fadds, half, one)
> +DO_FP_IMM(FSUB, fsubs, half, one)
> +DO_FP_IMM(FMUL, fmuls, half, two)
> +DO_FP_IMM(FSUBR, fsubrs, half, one)
> +DO_FP_IMM(FMAXNM, fmaxnms, zero, one)
> +DO_FP_IMM(FMINNM, fminnms, zero, one)
> +DO_FP_IMM(FMAX, fmaxs, zero, one)
> +DO_FP_IMM(FMIN, fmins, zero, one)
> +
> +#undef DO_FP_IMM
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v5 11/35] target/arm: Implement SVE scatter stores, (continued)
- [Qemu-devel] [PATCH v5 11/35] target/arm: Implement SVE scatter stores, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 15/35] target/arm: Implement SVE scatter store vector immediate, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 14/35] target/arm: Implement SVE first-fault gather loads, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 16/35] target/arm: Implement SVE floating-point compare vectors, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 17/35] target/arm: Implement SVE floating-point arithmetic with immediate, Richard Henderson, 2018/06/20
- Re: [Qemu-devel] [PATCH v5 17/35] target/arm: Implement SVE floating-point arithmetic with immediate,
Peter Maydell <=
- [Qemu-devel] [PATCH v5 18/35] target/arm: Implement SVE Floating Point Multiply Indexed Group, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 20/35] target/arm: Implement SVE Floating Point Unary Operations - Unpredicated Group, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 19/35] target/arm: Implement SVE FP Fast Reduction Group, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 22/35] target/arm: Implement SVE floating-point trig multiply-add coefficient, Richard Henderson, 2018/06/20
- [Qemu-devel] [PATCH v5 21/35] target/arm: Implement SVE FP Compare with Zero Group, Richard Henderson, 2018/06/20