Re: [Qemu-devel] [PATCH 6/6] linux-user: Use *at functions to implement interp_prefix

[Daniel P . Berrangé]

On Tue, Jun 05, 2018 at 02:23:56PM +0200, Laurent Vivier wrote:
> Le 05/06/2018 à 14:14, Peter Maydell a écrit :
> > On 5 June 2018 at 13:05, Laurent Vivier <address@hidden> wrote:
> >> Le 05/06/2018 à 12:52, Peter Maydell a écrit :
> >>> On 5 June 2018 at 06:27, Richard Henderson <address@hidden> wrote:
> >>>> On Fedora 28, one can no longer build a static qemu.  We depend on 
> >>>> libraries
> >>>> for which Fedora no longer ships static versions.
> >>>
> >>> Do you mean you can't build the system binaries statically (that's
> >>> never really been very supported), or that you can't do a build
> >>> with configure --disable-system --disable-tools --static ?
> >>>
> >>> The latter would be more concerning.
> >>
> >> On Fedora I have also to disable gcrypt, nettle and libiscsi because we
> >> don't have the statically linked libraries, but we don't need them with
> >> linux-user.
> > 
> > Do we actually try to link with those for linux-user? If not,
> > maybe we could make configure a bit more helpful about not
> > requiring you to manually --disable-foo them.
> 
> They are used by tests/qemu-iotests/socket_scm_helper and
> qemu-bridge-helper.
> 
> Perhaps we can disable qemu-iotests with linux-user only and to not
> build qemu-bridge-helper when tools are disabled?

Actually we should not build qemu-bridge-helper if all system emulator
builds are disabled, since its not intended as a standalone tool.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|