Re: [Qemu-devel] [PATCH v5 22/28] fpu/softfloat: Specialize on snan_bit_is_one

[Peter Maydell]

On 14 May 2018 at 23:12, Richard Henderson <address@hidden> wrote:
> Only MIPS requires snan_bit_is_one to be variable.  While we are
> specializing softfloat behaviour, allow other targets to eliminate
> this runtime check.
>
> Cc: Aurelien Jarno <address@hidden>
> Cc: Yongbok Kim <address@hidden>
> Cc: David Gibson <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: Guan Xuetao <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
>
> ---
> v5
>   - do not remove the set_snan_bit_is_one function
>   - tidy the language in the snan_bit_is_one block comment

Reviewed-by: Peter Maydell <address@hidden>

I think this change makes the comments in target/riscv/fpu_helper.c
helper_fclass_s() and helper_fclass_d() stale, incidentally.

thanks
-- PMM