[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 26/28] fpu/softfloat: Define floatN_default_n
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v5 26/28] fpu/softfloat: Define floatN_default_nan in terms of parts_default_nan |
Date: |
Tue, 15 May 2018 11:38:45 +0100 |
On 14 May 2018 at 23:12, Richard Henderson <address@hidden> wrote:
> Isolate the target-specific choice to 2 functions instead of 6.
>
> The code in float16_default_nan was only correct for ARM, MIPS, and X86.
> Though float16 support is rare among our targets.
>
> The code in float128_default_nan was arguably wrong for Sparc. While
> QEMU supports the Sparc 128-bit insns, no real cpu enables it.
>
> The code in floatx80_default_nan tried to be over-general. There are
> only two targets that support this format: x86 and m68k. Thus there
> is no point in inventing a value for snan_bit_is_one.
>
> Move routines that no longer have ifdefs out of softfloat-specialize.h.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
This patch results in float32_default_nan() for Arm returning 0x7f800000,
which is not a NaN...
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v5 23/28] fpu/softfloat: Make is_nan et al available to softfloat-specialize.h, (continued)
- [Qemu-devel] [PATCH v5 24/28] fpu/softfloat: Pass FloatClass to pickNaN, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 25/28] fpu/softfloat: Pass FloatClass to pickNaNMulAdd, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 21/28] fpu/softfloat: Remove floatX_maybe_silence_nan, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 22/28] fpu/softfloat: Specialize on snan_bit_is_one, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 26/28] fpu/softfloat: Define floatN_default_nan in terms of parts_default_nan, Richard Henderson, 2018/05/14
- Re: [Qemu-devel] [PATCH v5 26/28] fpu/softfloat: Define floatN_default_nan in terms of parts_default_nan,
Peter Maydell <=
- [Qemu-devel] [PATCH v5 27/28] fpu/softfloat: Clean up parts_default_nan, Richard Henderson, 2018/05/14
- [Qemu-devel] [PATCH v5 28/28] fpu/softfloat: Define floatN_silence_nan in terms of parts_silence_nan, Richard Henderson, 2018/05/14
- Re: [Qemu-devel] [PATCH v5 00/28] softfloat patch roundup, Alex Bennée, 2018/05/15
- Re: [Qemu-devel] [PATCH v5 00/28] softfloat patch roundup, Alex Bennée, 2018/05/15