Re: [Qemu-devel] [PATCH 5/9] target/arm: Implement FMOV (general) for fp16

[Richard Henderson]

On 04/24/2018 03:31 PM, Philippe Mathieu-Daudé wrote:
>> @@ -5431,10 +5446,15 @@ static void disas_fp_int_conv(DisasContext *s, 
>> uint32_t insn)
>>          case 0xa: /* 64 bit */
>>          case 0xd: /* 64 bit to top half of quad */
>>              break;
>> +        case 0x6: /* 16-bit */
>> +            if (arm_dc_feature(s, ARM_FEATURE_V8_FP16)) {
>> +                break;
>> +            }
>> +            /* fallthru */
>>          default:
>>              /* all other sf/type/rmode combinations are invalid */
>>              unallocated_encoding(s);
>> -            break;
>> +            return;
> 
> Agreed with this change, however shouldn't this be in a separate patch?

Why?


r~