Re: [Qemu-devel] [PATCH 00/13] Drop compile time limit on number of serial ports

[Peter Maydell]

On 20 April 2018 at 16:10,  <address@hidden> wrote:

> Checking PATCH 7/13: Change references to serial_hds[] to serial_hd()...
> WARNING: line over 80 characters
> #581: FILE: hw/cris/axis_dev88.c:340:
> +        etraxfs_ser_create(0x30026000 + i * 0x2000, irq[0x14 + i], 
> serial_hd(i));
>
> ERROR: spaces required around that '/' (ctx:VxV)
> #824: FILE: hw/moxie/moxiesim.c:146:
> +                       8000000/16, serial_hd(0), DEVICE_LITTLE_ENDIAN);
>                                ^
>
> total: 1 errors, 1 warnings, 852 lines checked

These are in the "mechanical change only" patch, so I didn't
want to change anything else there.

> Checking PATCH 12/13: vl.c: Remove compile time limit on number of serial 
> ports...
> ERROR: do not initialise statics to 0 or NULL
> #35: FILE: vl.c:157:
> +static int num_serial_hds = 0;
>
> ERROR: do not initialise statics to 0 or NULL
> #36: FILE: vl.c:158:
> +static Chardev **serial_hds = NULL;

I'd forgotten checkpatch had this requirement; easy to fix.

thanks
-- PMM