Re: [Qemu-devel] [PULL 0/1] pc: bugfix

[Peter Maydell]

On 20 April 2018 at 16:06, Michael S. Tsirkin <address@hidden> wrote:
> On Fri, Apr 20, 2018 at 03:55:31PM +0100, Peter Maydell wrote:
>> On 20 April 2018 at 15:29, Michael S. Tsirkin <address@hidden> wrote:
>> > The following changes since commit 
>> > 27e757e29cc79f3f104d2a84d17cdb3b4c11c8ff:
>> >
>> >   Update version for v2.12.0-rc4 release (2018-04-17 22:26:44 +0100)
>> >
>> > are available in the git repository at:
>> >
>> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>> >
>> > for you to fetch changes up to f256f05c94d12eed2c1a0e9b6ed4fb1fb9d8ec72:
>> >
>> >   intel-iommu: send PSI always when notify_unmap set (2018-04-20 17:26:23 
>> > +0300)
>> >
>> > ----------------------------------------------------------------
>> > pc: bugfix
>> >
>> > Adds missing invalidations in vtd.
>> >
>> > Signed-off-by: Michael S. Tsirkin <address@hidden>
>> >
>> > ----------------------------------------------------------------
>> > Peter Xu (1):
>> >       intel-iommu: send PSI always when notify_unmap set
>>
>> You really can't send me a pull request at rc4 and expect
>> me to apply it without a very clear and detailed rationale
>> in the cover letter for why this bug fix justifies having
>> to roll an extra rc and delay the release. "bugfix" is
>> not sufficient, I'm afraid.

> Right, sorry about that.  It fixes a security problem unfortunately.
> Would you like me to redo it with a more detailed description?

Would be nice. The commit message as it sounds certainly
doesn't sound like a security problem. Does this have a CVE?
If so the commit message should state it. Should it be cc:stable?
Is it a regression since 2.11? What exactly are the consequences
and who does it affect?

It's probably easier if you explain in email here first, and
then we can redo the commit message if it seems necessary.

thanks
-- PMM