[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/17] target/s390x: convert to DisasContextB
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 11/17] target/s390x: convert to DisasContextBase |
Date: |
Tue, 10 Apr 2018 14:07:53 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/07/2018 04:19 AM, Emilio G. Cota wrote:
> Notes:
>
> - Did not convert {num,max}_insns and is_jmp, since the corresponding
> code will go away in the next patch.
>
> - Avoided a checkpatch error in use_exit_tb.
>
> - As suggested by David, (1) Drop ctx.pc and use
> ctx.base.pc_next instead, and (2) Rename ctx.next_pc to
> ctx.pc_tmp and add a comment about it.
>
> Acked-by: Cornelia Huck <address@hidden>
> Suggested-by: David Hildenbrand <address@hidden>
> Reviewed-by: David Hildenbrand <address@hidden>
> Cc: David Hildenbrand <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: address@hidden
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/s390x/translate.c | 148
> ++++++++++++++++++++++++-----------------------
> 1 file changed, 76 insertions(+), 72 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v2 04/17] target/sparc: convert to DisasContextBase, (continued)
[Qemu-devel] [PATCH v2 08/17] target/mips: use *ctx for DisasContext, Emilio G. Cota, 2018/04/06
[Qemu-devel] [PATCH v2 11/17] target/s390x: convert to DisasContextBase, Emilio G. Cota, 2018/04/06
- Re: [Qemu-devel] [PATCH v2 11/17] target/s390x: convert to DisasContextBase,
Richard Henderson <=
[Qemu-devel] [PATCH v2 01/17] translator: merge max_insns into DisasContextBase, Emilio G. Cota, 2018/04/06
[Qemu-devel] [PATCH v2 09/17] target/mips: convert to TranslatorOps, Emilio G. Cota, 2018/04/06
[Qemu-devel] [PATCH v2 15/17] target/riscv: convert to DisasJumpType, Emilio G. Cota, 2018/04/06
[Qemu-devel] [PATCH v2 17/17] target/riscv: convert to TranslatorOps, Emilio G. Cota, 2018/04/06