qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 08/17] target/mips: use *ctx for DisasContext


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 08/17] target/mips: use *ctx for DisasContext
Date: Tue, 10 Apr 2018 13:57:53 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 04/07/2018 04:19 AM, Emilio G. Cota wrote:
> No changes to the logic here; this is just to make the diff
> that follows easier to read.
> 
> While at it, remove the unnecessary 'struct' in
> 'struct TranslationBlock'.
> 
> Note that checkpatch complains with a false positive:
>   ERROR: space prohibited after that '&' (ctx:WxW)
>   #75: FILE: target/mips/translate.c:20220:
>   +    ctx->kscrexist = (env->CP0_Config4 >> CP0C4_KScrExist) & 0xff;
>                                                               ^
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> Cc: Aurelien Jarno <address@hidden>
> Cc: Yongbok Kim <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  target/mips/translate.c | 166 
> ++++++++++++++++++++++++------------------------
>  1 file changed, 84 insertions(+), 82 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]