[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig" |
Date: |
Fri, 23 Mar 2018 18:28:37 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Mon, Mar 12, 2018 at 02:11:11PM +0100, Igor Mammedov wrote:
> New option will be used to allow commands, which are prepared/need
> to run run in preconfig state. Other commands that should be able
> to run in preconfig state, should be ammeded to not expect machine
> in initialized state or deal with it.
>
> For compatibility reasons, commands, that don't use new flag
> 'allowed-in-preconfig' explicitly, are not permited to run in
> preconfig state but allowed in all other states like they used
> to be.
>
> Within this patch allow following commands in preconfig state:
> qmp_capabilities
> query-qmp-schema
> query-commands
> query-status
> cont
> to allow qmp connection, basic introspection and moving to the next
> state.
>
> PS:
> set-numa-node and query-hotpluggable-cpus will be enabled later in
> a separate patch.
>
> Signed-off-by: Igor Mammedov <address@hidden>
I didn't review the code yet, but:
Shouldn't this be applied before patch 3/9, for bisectability?
Otherwise it will be very easy to crash QEMU after applying patch
3/9.
--
Eduardo
[Qemu-devel] [PATCH v4 5/9] qapi: introduce new cmd option "allowed-in-preconfig", Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 8/9] qmp: add set-numa-node command, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 9/9] tests: functional tests for QMP command set-numa-node, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 7/9] qmp: permit query-hotpluggable-cpus in preconfig state, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 6/9] tests: extend qmp test with preconfig checks, Igor Mammedov, 2018/03/12