[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS hands
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake |
Date: |
Thu, 1 Mar 2018 18:22:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 01/03/2018 09:44, Peter Xu wrote:
> +/**
> + * qio_channel_tls_handshake_full:
> + * @ioc: the TLS channel object
> + * @func: the callback to invoke when completed
> + * @opaque: opaque data to pass to @func
> + * @destroy: optional callback to free @opaque
> + * @context: the context that TLS handshake will run with
> + *
> + * Similar to qio_channel_tls_handshake(), but allows the task to be
> + * run on a specific context.
> + */
> +void qio_channel_tls_handshake_full(QIOChannelTLS *ioc,
> + QIOTaskFunc func,
> + gpointer opaque,
> + GDestroyNotify destroy,
> + GMainContext *context);
> +
You're not consistent in introducing "_full" functions. I would
add the argument directly to the qio_channel_tls_handshake() function.
Paolo
- Re: [Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switch gcontext, (continued)
- [Qemu-devel] [PATCH v2 10/15] qio: non-default context for async conn, Peter Xu, 2018/03/01
- [Qemu-devel] [PATCH v2 09/15] qio: non-default context for threaded qtask, Peter Xu, 2018/03/01
- [Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake, Peter Xu, 2018/03/01
- [Qemu-devel] [PATCH v2 12/15] chardev: introduce chr_machine_done hook, Peter Xu, 2018/03/01
- [Qemu-devel] [PATCH v2 13/15] char: use chardev's gcontext for async connect, Peter Xu, 2018/03/01
- [Qemu-devel] [PATCH v2 14/15] chardev: tcp: postpone async connection setup, Peter Xu, 2018/03/01
- [Qemu-devel] [PATCH v2 15/15] chardev: tcp: postpone TLS work until machine done, Peter Xu, 2018/03/01