[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/15] qio: non-default context for async con
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/15] qio: non-default context for async conn |
Date: |
Thu, 1 Mar 2018 15:48:44 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, Mar 01, 2018 at 04:44:33PM +0800, Peter Xu wrote:
> We have worked on qio_task_run_in_thread() already. Further, let
> qio_channel_socket_connect_async() pass that context to it.
>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> chardev/char-socket.c | 4 ++--
> include/io/channel-socket.h | 4 +++-
> io/channel-socket.c | 5 +++--
> migration/socket.c | 3 ++-
> tests/test-io-channel-socket.c | 2 +-
> 5 files changed, 11 insertions(+), 7 deletions(-)
> diff --git a/include/io/channel-socket.h b/include/io/channel-socket.h
> index 53801f6042..90f7227397 100644
> --- a/include/io/channel-socket.h
> +++ b/include/io/channel-socket.h
> @@ -101,6 +101,7 @@ int qio_channel_socket_connect_sync(QIOChannelSocket *ioc,
> * @callback: the function to invoke on completion
> * @opaque: user data to pass to @callback
> * @destroy: the function to free @opaque
> + * @context: the context to run the async task
> *
> * Attempt to connect to the address @addr. This method
> * will run in the background so the caller will regain
> @@ -113,7 +114,8 @@ void qio_channel_socket_connect_async(QIOChannelSocket
> *ioc,
> SocketAddress *addr,
> QIOTaskFunc callback,
> gpointer opaque,
> - GDestroyNotify destroy);
> + GDestroyNotify destroy,
> + GMainContext *context);
If you're going to add a GMainContext() to connect_async, then please
also do it for listen_async and dgram_async at the same time, so we
remain consistent in API design.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH v2 07/15] qio/chardev: update net listener gcontext, (continued)
[Qemu-devel] [PATCH v2 08/15] chardev: allow telnet gsource to switch gcontext, Peter Xu, 2018/03/01
[Qemu-devel] [PATCH v2 10/15] qio: non-default context for async conn, Peter Xu, 2018/03/01
- Re: [Qemu-devel] [PATCH v2 10/15] qio: non-default context for async conn,
Daniel P . Berrangé <=
[Qemu-devel] [PATCH v2 09/15] qio: non-default context for threaded qtask, Peter Xu, 2018/03/01
[Qemu-devel] [PATCH v2 11/15] qio: non-default context for TLS handshake, Peter Xu, 2018/03/01
[Qemu-devel] [PATCH v2 12/15] chardev: introduce chr_machine_done hook, Peter Xu, 2018/03/01