[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 10/14] configure: allow use of python 3
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 10/14] configure: allow use of python 3 |
Date: |
Tue, 16 Jan 2018 08:51:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 01/16/2018 07:42 AM, Daniel P. Berrange wrote:
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> configure | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
Presumably, you tested with this patch first in the series to come up
with patches 1-9 ;)
> diff --git a/configure b/configure
> index b272a0336b..60b99f45f6 100755
> --- a/configure
> +++ b/configure
> @@ -1598,9 +1598,8 @@ fi
>
> # Note that if the Python conditional here evaluates True we will exit
> # with status 1 which is a shell 'false' value.
> -if ! $python -c 'import sys; sys.exit(sys.version_info < (2,6) or
> sys.version_info >= (3,))'; then
> - error_exit "Cannot use '$python', Python 2.6 or later is required." \
> - "Note that Python 3 or later is not yet supported." \
> +if ! $python -c 'import sys; sys.exit(sys.version_info < (2,6))'; then
> + error_exit "Cannot use '$python', Python 2 >= 2.6 or Python 3 is
> required." \
> "Use --python=/path/to/python to specify a supported Python."
> fi
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 00/14] Support building with py2 or py3, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 01/14] qapi: convert to use python print function instead of statement, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 02/14] qapi: use items()/values() intead of iteritems()/itervalues(), Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 03/14] qapi: Use OrderedDict from standard library if available, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 04/14] qapi: adapt to moved location of StringIO module in py3, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 05/14] qapi: Adapt to moved location of 'maketrans' function in py3, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 07/14] qapi: ensure stable sort ordering when checking QAPI entities, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 10/14] configure: allow use of python 3, Daniel P. Berrange, 2018/01/16
- Re: [Qemu-devel] [PATCH v5 10/14] configure: allow use of python 3,
Eric Blake <=
- [Qemu-devel] [PATCH v5 09/14] scripts: ensure signrom treats data as bytes, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 08/14] qapi: force a UTF-8 locale for running Python, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 11/14] input: add missing JIS keys to virtio input, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 13/14] travis: improve python version test coverage, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 12/14] ui: update keycodemapdb to get py3 fixes, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 14/14] docker: change Fedora images to run with python3, Daniel P. Berrange, 2018/01/16
- Re: [Qemu-devel] [PATCH v5 00/14] Support building with py2 or py3, Eduardo Habkost, 2018/01/19