[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when compari
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output |
Date: |
Tue, 16 Jan 2018 13:42:09 +0000 |
When the qapi schema tests fail they merely print that the expected
output didn't match the actual output. This is largely useless when
trying diagnose what went wrong. Removing the '-q' arg to diff
means that it is still silent on successful tests, but when it
fails we'll see details of the incorrect output.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
---
tests/Makefile.include | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 39a4b5359d..d65fb4e1b3 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -908,10 +908,10 @@ $(patsubst %, check-%, $(check-qapi-schema-y)):
check-%.json: $(SRC_PATH)/%.json
$^ >$*.test.out 2>$*.test.err; \
echo $$? >$*.test.exit, \
"TEST","$*.out")
- @diff -q $(SRC_PATH)/$*.out $*.test.out
+ @diff $(SRC_PATH)/$*.out $*.test.out
@# Sanitize error messages (make them independent of build directory)
- @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff -q
$(SRC_PATH)/$*.err -
- @diff -q $(SRC_PATH)/$*.exit $*.test.exit
+ @perl -p -e 's|\Q$(SRC_PATH)\E/||g' $*.test.err | diff
$(SRC_PATH)/$*.err -
+ @diff $(SRC_PATH)/$*.exit $*.test.exit
.PHONY: check-tests/qapi-schema/doc-good.texi
check-tests/qapi-schema/doc-good.texi: tests/qapi-schema/doc-good.test.texi
--
2.14.3
- [Qemu-devel] [PATCH v5 00/14] Support building with py2 or py3, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 01/14] qapi: convert to use python print function instead of statement, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 02/14] qapi: use items()/values() intead of iteritems()/itervalues(), Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 03/14] qapi: Use OrderedDict from standard library if available, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 04/14] qapi: adapt to moved location of StringIO module in py3, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 05/14] qapi: Adapt to moved location of 'maketrans' function in py3, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v5 07/14] qapi: ensure stable sort ordering when checking QAPI entities, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 10/14] configure: allow use of python 3, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 09/14] scripts: ensure signrom treats data as bytes, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 08/14] qapi: force a UTF-8 locale for running Python, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 11/14] input: add missing JIS keys to virtio input, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 13/14] travis: improve python version test coverage, Daniel P. Berrange, 2018/01/16
- [Qemu-devel] [PATCH v5 12/14] ui: update keycodemapdb to get py3 fixes, Daniel P. Berrange, 2018/01/16