[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 6/7] vhost: Clean out old vhost_set_memory an
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v5 6/7] vhost: Clean out old vhost_set_memory and friends |
Date: |
Tue, 9 Jan 2018 15:54:16 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Igor Mammedov (address@hidden) wrote:
> On Mon, 18 Dec 2017 20:13:39 +0000
> "Dr. David Alan Gilbert (git)" <address@hidden> wrote:
>
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > Remove the old update mechanism, vhost_set_memory, and the functions
> > and flags it used.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> [...]
>
> > -
> > -static void vhost_set_memory(MemoryListener *listener,
> > - MemoryRegionSection *section,
> > - bool add)
> > -{
> [...]
>
> > - used_memslots = dev->mem->nregions;
> lost sheep?
Yes, I've moved that into the previous patch, ( vhost: Regenerate region
list from changed sections list ) so it now has:
...
dev->mem = g_realloc(dev->mem, regions_size);
dev->mem->nregions = dev->n_mem_sections;
used_memslots = dev->mem->nregions;
for (i = 0; i < dev->n_mem_sections; i++) {
...
> pls,
> see "[PATCH v2 0/2] vhost: two fixes" to get vague idea how used_memslots is
> used
Yes, that series does make it better because what confused me about the
current use of used_memslots is it seems obviously unsafe for multiple
devices.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v5 6/7] vhost: Clean out old vhost_set_memory and friends,
Dr. David Alan Gilbert <=