[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/18] ne2000: use inline net_crc32() and bitshift in
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 13/18] ne2000: use inline net_crc32() and bitshift instead of compute_mcast_idx() |
Date: |
Fri, 22 Dec 2017 10:15:32 +0800 |
From: Mark Cave-Ayland <address@hidden>
This makes it much easier to compare the multicast CRC calculation endian and
bitshift against the Linux driver implementation.
Signed-off-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/ne2000.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
index 6874c8c..687ef84 100644
--- a/hw/net/ne2000.c
+++ b/hw/net/ne2000.c
@@ -23,6 +23,8 @@
*/
#include "qemu/osdep.h"
#include "hw/pci/pci.h"
+#include "net/net.h"
+#include "net/eth.h"
#include "ne2000.h"
#include "hw/loader.h"
#include "sysemu/sysemu.h"
@@ -199,7 +201,7 @@ ssize_t ne2000_receive(NetClientState *nc, const uint8_t
*buf, size_t size_)
/* multicast */
if (!(s->rxcr & 0x08))
return size;
- mcast_idx = compute_mcast_idx(buf);
+ mcast_idx = net_crc32(buf, ETH_ALEN) >> 26;
if (!(s->mult[mcast_idx >> 3] & (1 << (mcast_idx & 7))))
return size;
} else if (s->mem[0] == buf[0] &&
--
2.7.4
- [Qemu-devel] [PULL 03/18] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function, (continued)
- [Qemu-devel] [PULL 03/18] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 04/18] net: introduce net_crc32_le() function, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 05/18] pcnet: switch pcnet over to use net_crc32_le(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 06/18] eepro100: switch eepro100 e100_compute_mcast_idx() over to use net_crc32(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 07/18] sunhme: switch sunhme over to use net_crc32_le(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 08/18] sungem: fix multicast filter CRC calculation, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 09/18] eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 10/18] opencores_eth: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 11/18] lan9118: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 12/18] ftgmac100: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 13/18] ne2000: use inline net_crc32() and bitshift instead of compute_mcast_idx(),
Jason Wang <=
- [Qemu-devel] [PULL 14/18] rtl8139: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 15/18] net: remove unused compute_mcast_idx() function, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 16/18] net: Remove the legacy "-net channel" parameter, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 17/18] qemu-doc: The "-net nic" option can be used with "netdev=...", too, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 18/18] qemu-doc: Update the deprecation information of -tftp, -bootp, -redir and -smb, Jason Wang, 2017/12/21