[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 08/18] sungem: fix multicast filter CRC calculation
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 08/18] sungem: fix multicast filter CRC calculation |
Date: |
Fri, 22 Dec 2017 10:15:27 +0800 |
From: Mark Cave-Ayland <address@hidden>
>From the Linux sungem driver, we know that the multicast filter CRC is
implemented using ether_crc_le() which isn't the same as calling zlib's
crc32() function (the zlib implementation requires a complemented initial value
and also returns the complemented result).
Fix the multicast filter by simply using the new net_crc32_le() function.
Signed-off-by: Mark Cave-Ayland <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/sungem.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/net/sungem.c b/hw/net/sungem.c
index 6aa8d11..60f1e47 100644
--- a/hw/net/sungem.c
+++ b/hw/net/sungem.c
@@ -11,12 +11,11 @@
#include "hw/pci/pci.h"
#include "qemu/log.h"
#include "net/net.h"
+#include "net/eth.h"
#include "net/checksum.h"
#include "hw/net/mii.h"
#include "sysemu/sysemu.h"
#include "trace.h"
-/* For crc32 */
-#include <zlib.h>
#define TYPE_SUNGEM "sungem"
@@ -595,7 +594,7 @@ static ssize_t sungem_receive(NetClientState *nc, const
uint8_t *buf,
}
/* Get MAC crc */
- mac_crc = crc32(~0, buf, 6);
+ mac_crc = net_crc32_le(buf, ETH_ALEN);
/* Packet isn't for me ? */
rx_cond = sungem_check_rx_mac(s, buf, mac_crc);
--
2.7.4
- [Qemu-devel] [PULL 00/18] Net patches, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 01/18] e1000, e1000e: Move per-packet TX offload flags out of context state, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 02/18] e1000: Separate TSO and non-TSO contexts, fixing UDP TX corruption, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 03/18] net: move CRC32 calculation from compute_mcast_idx() into its own net_crc32() function, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 04/18] net: introduce net_crc32_le() function, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 05/18] pcnet: switch pcnet over to use net_crc32_le(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 06/18] eepro100: switch eepro100 e100_compute_mcast_idx() over to use net_crc32(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 07/18] sunhme: switch sunhme over to use net_crc32_le(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 08/18] sungem: fix multicast filter CRC calculation,
Jason Wang <=
- [Qemu-devel] [PULL 09/18] eepro100: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 10/18] opencores_eth: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 11/18] lan9118: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 12/18] ftgmac100: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 13/18] ne2000: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 14/18] rtl8139: use inline net_crc32() and bitshift instead of compute_mcast_idx(), Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 15/18] net: remove unused compute_mcast_idx() function, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 16/18] net: Remove the legacy "-net channel" parameter, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 17/18] qemu-doc: The "-net nic" option can be used with "netdev=...", too, Jason Wang, 2017/12/21
- [Qemu-devel] [PULL 18/18] qemu-doc: Update the deprecation information of -tftp, -bootp, -redir and -smb, Jason Wang, 2017/12/21