[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/6] target/sh4: fix TCG leak during gusa sequence
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] [PULL 2/6] target/sh4: fix TCG leak during gusa sequence |
Date: |
Mon, 18 Dec 2017 23:40:26 +0100 |
From: Alex Bennée <address@hidden>
This fixes bug #1735384 while running java under qemu-sh4. When debug
was enabled it showed a problem with TCG temps. Once fixed I was able
to run java -version normally.
Cc: address@hidden
Reported-by: John Paul Adrian Glaubitz <address@hidden>
Suggested-by: Richard Henderson <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Aurelien Jarno <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>
---
target/sh4/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index f56808b45d..4a4a5c877e 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -2191,7 +2191,7 @@ static int decode_gusa(DisasContext *ctx, CPUSH4State
*env, int *pmax_insns)
}
/* If op_src is not a valid register, then op_arg was a constant. */
- if (op_src < 0) {
+ if (op_src < 0 && !TCGV_IS_UNUSED(op_arg)) {
tcg_temp_free_i32(op_arg);
}
--
2.15.1
- [Qemu-devel] [PULL 0/6] Queued target/sh4 patches, Aurelien Jarno, 2017/12/18
- [Qemu-devel] [PULL 1/6] target/sh4: add missing tcg_temp_free() in _decode_opc(), Aurelien Jarno, 2017/12/18
- [Qemu-devel] [PULL 3/6] target/sh4: Use cmpxchg for movco when parallel_cpus, Aurelien Jarno, 2017/12/18
- [Qemu-devel] [PULL 2/6] target/sh4: fix TCG leak during gusa sequence,
Aurelien Jarno <=
- [Qemu-devel] [PULL 4/6] target/sh4: Convert to DisasJumpType, Aurelien Jarno, 2017/12/18
- [Qemu-devel] [PULL 6/6] target/sh4: Convert to DisasContextBase, Aurelien Jarno, 2017/12/18
- [Qemu-devel] [PULL 5/6] target/sh4: Do not singlestep after exceptions, Aurelien Jarno, 2017/12/18
- Re: [Qemu-devel] [PULL 0/6] Queued target/sh4 patches, Peter Maydell, 2017/12/19