[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/6] hw/arm/palm.c: Don't use old_mmio for static_op
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 1/6] hw/arm/palm.c: Don't use old_mmio for static_ops |
Date: |
Sat, 16 Sep 2017 17:46:13 +0100 |
Update the static_ops functions to use new-style mmio
rather than the legacy old_mmio functions.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/arm/palm.c | 30 ++++++++++--------------------
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/hw/arm/palm.c b/hw/arm/palm.c
index bf070a2..264f5bd 100644
--- a/hw/arm/palm.c
+++ b/hw/arm/palm.c
@@ -30,26 +30,16 @@
#include "hw/loader.h"
#include "exec/address-spaces.h"
-static uint32_t static_readb(void *opaque, hwaddr offset)
+static uint64_t static_read(void *opaque, hwaddr offset, unsigned size)
{
- uint32_t *val = (uint32_t *) opaque;
- return *val >> ((offset & 3) << 3);
-}
+ uint32_t *val = (uint32_t *)opaque;
+ uint32_t sizemask = 7 >> size;
-static uint32_t static_readh(void *opaque, hwaddr offset)
-{
- uint32_t *val = (uint32_t *) opaque;
- return *val >> ((offset & 1) << 3);
-}
-
-static uint32_t static_readw(void *opaque, hwaddr offset)
-{
- uint32_t *val = (uint32_t *) opaque;
- return *val >> ((offset & 0) << 3);
+ return *val >> ((offset & sizemask) << 3);
}
-static void static_write(void *opaque, hwaddr offset,
- uint32_t value)
+static void static_write(void *opaque, hwaddr offset, uint64_t value,
+ unsigned size)
{
#ifdef SPY
printf("%s: value %08lx written at " PA_FMT "\n",
@@ -58,10 +48,10 @@ static void static_write(void *opaque, hwaddr offset,
}
static const MemoryRegionOps static_ops = {
- .old_mmio = {
- .read = { static_readb, static_readh, static_readw, },
- .write = { static_write, static_write, static_write, },
- },
+ .read = static_read,
+ .write = static_write,
+ .valid.min_access_size = 1,
+ .valid.max_access_size = 4,
.endianness = DEVICE_NATIVE_ENDIAN,
};
--
2.7.4
- [Qemu-devel] [PATCH 6/6] hw/arm/omap2.c: Don't use old_mmio, (continued)
- [Qemu-devel] [PATCH 6/6] hw/arm/omap2.c: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 5/6] hw/i2c/omap_i2c.c: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 4/6] hw/timer/omap_gptimer: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 3/6] hw/timer/omap_synctimer.c: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 2/6] hw/gpio/omap_gpio.c: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 1/6] hw/arm/palm.c: Don't use old_mmio for static_ops,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH 0/6] convert some omap/palm devices from using old_mmio, Mark Cave-Ayland, 2017/09/17