[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] hw/timer/omap_gptimer: Don't use old_mmio
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 4/6] hw/timer/omap_gptimer: Don't use old_mmio |
Date: |
Sat, 16 Sep 2017 17:46:16 +0100 |
Don't use the old_mmio struct in memory region ops.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/timer/omap_gptimer.c | 49 +++++++++++++++++++++++++++++++++++++------------
1 file changed, 37 insertions(+), 12 deletions(-)
diff --git a/hw/timer/omap_gptimer.c b/hw/timer/omap_gptimer.c
index 5e3e8a6..6d7c8a3 100644
--- a/hw/timer/omap_gptimer.c
+++ b/hw/timer/omap_gptimer.c
@@ -450,19 +450,44 @@ static void omap_gp_timer_writeh(void *opaque, hwaddr
addr,
s->writeh = (uint16_t) value;
}
+static uint64_t omap_gp_timer_readfn(void *opaque, hwaddr addr,
+ unsigned size)
+{
+ switch (size) {
+ case 1:
+ return omap_badwidth_read32(opaque, addr);
+ case 2:
+ return omap_gp_timer_readh(opaque, addr);
+ case 4:
+ return omap_gp_timer_readw(opaque, addr);
+ default:
+ g_assert_not_reached();
+ }
+}
+
+static void omap_gp_timer_writefn(void *opaque, hwaddr addr,
+ uint64_t value, unsigned size)
+{
+ switch (size) {
+ case 1:
+ omap_badwidth_write32(opaque, addr, value);
+ break;
+ case 2:
+ omap_gp_timer_writeh(opaque, addr, value);
+ break;
+ case 4:
+ omap_gp_timer_write(opaque, addr, value);
+ break;
+ default:
+ g_assert_not_reached();
+ }
+}
+
static const MemoryRegionOps omap_gp_timer_ops = {
- .old_mmio = {
- .read = {
- omap_badwidth_read32,
- omap_gp_timer_readh,
- omap_gp_timer_readw,
- },
- .write = {
- omap_badwidth_write32,
- omap_gp_timer_writeh,
- omap_gp_timer_write,
- },
- },
+ .read = omap_gp_timer_readfn,
+ .write = omap_gp_timer_writefn,
+ .valid.min_access_size = 1,
+ .valid.max_access_size = 4,
.endianness = DEVICE_NATIVE_ENDIAN,
};
--
2.7.4
- [Qemu-devel] [PATCH 0/6] convert some omap/palm devices from using old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 6/6] hw/arm/omap2.c: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 5/6] hw/i2c/omap_i2c.c: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 4/6] hw/timer/omap_gptimer: Don't use old_mmio,
Peter Maydell <=
- [Qemu-devel] [PATCH 3/6] hw/timer/omap_synctimer.c: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 2/6] hw/gpio/omap_gpio.c: Don't use old_mmio, Peter Maydell, 2017/09/16
- [Qemu-devel] [PATCH 1/6] hw/arm/palm.c: Don't use old_mmio for static_ops, Peter Maydell, 2017/09/16
- Re: [Qemu-devel] [PATCH 0/6] convert some omap/palm devices from using old_mmio, Mark Cave-Ayland, 2017/09/17