[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/23] tcg/arm: Use constant pool for call
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 20/23] tcg/arm: Use constant pool for call |
Date: |
Thu, 7 Sep 2017 15:40:48 -0700 |
From: Richard Henderson <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/arm/tcg-target.inc.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c
index 2736022d5a..db46aea38c 100644
--- a/tcg/arm/tcg-target.inc.c
+++ b/tcg/arm/tcg-target.inc.c
@@ -1054,10 +1054,7 @@ static void tcg_out_goto(TCGContext *s, int cond,
tcg_insn_unit *addr)
tcg_out_b(s, cond, disp);
return;
}
-
- assert(use_armv5t_instructions || (addri & 1) == 0);
- tcg_out_movi32(s, cond, TCG_REG_TMP, addri);
- tcg_out_bx(s, cond, TCG_REG_TMP);
+ tcg_out_movi_pool(s, cond, TCG_REG_PC, addri);
}
/* The call case is mostly used for helpers - so it's not unreasonable
@@ -1081,9 +1078,9 @@ static void tcg_out_call(TCGContext *s, tcg_insn_unit
*addr)
tcg_out_movi32(s, COND_AL, TCG_REG_TMP, addri);
tcg_out_blx(s, COND_AL, TCG_REG_TMP);
} else {
+ /* ??? Know that movi_pool emits exactly 2 insns. */
tcg_out_dat_imm(s, COND_AL, ARITH_ADD, TCG_REG_R14, TCG_REG_PC, 4);
- tcg_out_ld32_12(s, COND_AL, TCG_REG_PC, TCG_REG_PC, -4);
- tcg_out32(s, addri);
+ tcg_out_movi_pool(s, COND_AL, TCG_REG_PC, addri);
}
}
--
2.13.5
- [Qemu-devel] [PULL 10/23] tcg/s390: Use constant pool for xori, (continued)
- [Qemu-devel] [PULL 10/23] tcg/s390: Use constant pool for xori, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 11/23] tcg/s390: Use constant pool for cmpi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 12/23] tcg/aarch64: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 13/23] tcg/sparc: Introduce TCG_REG_TB, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 14/23] tcg/sparc: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 15/23] tcg/arm: Improve tlb load for armv7, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 16/23] tcg/arm: Tighten tlb indexing offset test, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 19/23] tcg/arm: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 17/23] tcg/arm: Code rearrangement, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 18/23] tcg/arm: Extract INSN_NOP, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 20/23] tcg/arm: Use constant pool for call,
Richard Henderson <=
- [Qemu-devel] [PULL 22/23] tcg/ppc: Look for shifted constants, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 23/23] tcg/ppc: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 21/23] tcg/ppc: Change TCG_REG_RA to TCG_REG_TB, Richard Henderson, 2017/09/07
- Re: [Qemu-devel] [PULL 00/23] tcg constant pools and USE_DIRECT_JUMP cleanup, Peter Maydell, 2017/09/08