[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/23] tcg/arm: Tighten tlb indexing offset test
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL 16/23] tcg/arm: Tighten tlb indexing offset test |
Date: |
Thu, 7 Sep 2017 15:40:44 -0700 |
From: Richard Henderson <address@hidden>
We are not going to use ldrd for loading the comparator
for 32-bit guests, so don't limit cmp_off to 8 bits then.
This eliminates one insn in the tlb load for some guests.
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/arm/tcg-target.inc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c
index 66c369c239..6c12b169ce 100644
--- a/tcg/arm/tcg-target.inc.c
+++ b/tcg/arm/tcg-target.inc.c
@@ -1202,7 +1202,9 @@ static TCGReg tcg_out_tlb_read(TCGContext *s, TCGReg
addrlo, TCGReg addrhi,
}
/* We checked that the offset is contained within 16 bits above. */
- if (add_off > 0xfff || (use_armv6_instructions && cmp_off > 0xff)) {
+ if (add_off > 0xfff
+ || (use_armv6_instructions && TARGET_LONG_BITS == 64
+ && cmp_off > 0xff)) {
tcg_out_dat_imm(s, COND_AL, ARITH_ADD, TCG_REG_R2, base,
(24 << 7) | (cmp_off >> 8));
base = TCG_REG_R2;
--
2.13.5
- [Qemu-devel] [PULL 06/23] tcg/s390: Fix sign of patch_reloc addend, (continued)
- [Qemu-devel] [PULL 06/23] tcg/s390: Fix sign of patch_reloc addend, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 08/23] tcg/s390: Use constant pool for andi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 09/23] tcg/s390: Use constant pool for ori, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 07/23] tcg/s390: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 10/23] tcg/s390: Use constant pool for xori, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 11/23] tcg/s390: Use constant pool for cmpi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 12/23] tcg/aarch64: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 13/23] tcg/sparc: Introduce TCG_REG_TB, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 14/23] tcg/sparc: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 15/23] tcg/arm: Improve tlb load for armv7, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 16/23] tcg/arm: Tighten tlb indexing offset test,
Richard Henderson <=
- [Qemu-devel] [PULL 19/23] tcg/arm: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 17/23] tcg/arm: Code rearrangement, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 18/23] tcg/arm: Extract INSN_NOP, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 20/23] tcg/arm: Use constant pool for call, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 22/23] tcg/ppc: Look for shifted constants, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 23/23] tcg/ppc: Use constant pool for movi, Richard Henderson, 2017/09/07
- [Qemu-devel] [PULL 21/23] tcg/ppc: Change TCG_REG_RA to TCG_REG_TB, Richard Henderson, 2017/09/07
- Re: [Qemu-devel] [PULL 00/23] tcg constant pools and USE_DIRECT_JUMP cleanup, Peter Maydell, 2017/09/08