qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 20/29] vhost-user-test: Drop dependence on gl


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v6 20/29] vhost-user-test: Drop dependence on global_qtest
Date: Tue, 5 Sep 2017 12:49:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 01.09.2017 20:03, Eric Blake wrote:
> Managing parallel connections to two different monitors via
> the implicit global_qtest makes it hard to copy-and-paste code
> to tests that are not aware of the implicit state.  Now that
> libqos is fully-explicit, it is easy to expand the rest of
> vhost-user-test to also use explicit state everywhere.
> 
> We can assert that the conversion is correct by checking that
> global_qtest remains NULL throughout the test (a later patch
> that changes global_qtest to not be a public global variable
> will drop the assertions).
> 
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  tests/vhost-user-test.c | 68 
> ++++++++++++++++++++++---------------------------
>  1 file changed, 30 insertions(+), 38 deletions(-)

Reviewed-by: Thomas Huth <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]