[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 22/29] tests/boot-sector: Drop dependence on
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v6 22/29] tests/boot-sector: Drop dependence on global_qtest |
Date: |
Tue, 5 Sep 2017 09:04:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 01.09.2017 20:03, Eric Blake wrote:
> As a general rule, we prefer avoiding implicit global state
> because it makes code harder to safely copy and paste without
> thinking about the global state. Adjust the helper code to
> use explicit state instead, and update all callers.
>
> Fix some trailing whitespace while touching the file.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
> tests/boot-sector.h | 6 ++++--
> tests/bios-tables-test.c | 2 +-
> tests/boot-sector.c | 8 ++++----
> tests/pxe-test.c | 2 +-
> tests/vmgenid-test.c | 2 +-
> 5 files changed, 11 insertions(+), 9 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [PATCH v6 14/29] libqos: Use explicit QTestState for fw_cfg operations, (continued)
[Qemu-devel] [PATCH v6 18/29] ivshmem-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
[Qemu-devel] [PATCH v6 20/29] vhost-user-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
[Qemu-devel] [PATCH v6 25/29] wdt_ib700-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
[Qemu-devel] [PATCH v6 22/29] tests/boot-sector: Drop dependence on global_qtest, Eric Blake, 2017/09/01
[Qemu-devel] [PATCH v6 21/29] qmp-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
[Qemu-devel] [PATCH v6 17/29] ahci-test: Drop dependence on global_qtest, Eric Blake, 2017/09/01
[Qemu-devel] [PATCH v6 23/29] tests/acpi-utils: Drop dependence on global_qtest, Eric Blake, 2017/09/01