Re: [Qemu-devel] [PATCH RFC 1/5] target/s390x: introduce internal.h

[David Hildenbrand]

On 11.08.2017 16:39, Thomas Huth wrote:
> On 11.08.2017 16:21, David Hildenbrand wrote:
>> On 11.08.2017 16:00, Thomas Huth wrote:
>>> On 11.08.2017 09:46, David Hildenbrand wrote:
>>>> cpu.h should only contain what really has to be accessed outside of
>>>> target/s390x/. Add internal.h which can only be used inside target/s390x/.
>>>>
>>>> Move everything that isn't fast enough to run away and restructure it
>>>> right away.
>>>>
>>>> Minor style fixes to avoid checkpatch warning to:
>>>> - struct Lowcore: "{" goes into same line as typedef
>>>> - struct LowCore: add spaces around "-" in array length calculations
>>>> - time2tod() and tod2time(): move "{" to separate line
>>>> - get_per_atmid(): add space between ")" and "?". Move cases by one char.
>>>> - get_per_atmid(): drop extra paremthesis around (1 << 6)
>>>>
>>>> Signed-off-by: David Hildenbrand <address@hidden>
>>>> ---
>>> [...]
>>>> diff --git a/target/s390x/internal.h b/target/s390x/internal.h
>>>> new file mode 100644
>>>> index 0000000..9a55271
>>>> --- /dev/null
>>>> +++ b/target/s390x/internal.h
>>>> @@ -0,0 +1,560 @@
>>>> +/*
>>>> + * s390x internal definitions and helpers
>>>> + *
>>>> + *  Copyright (c) 2009 Ulrich Hecht
>>>> + *
>>>> + * This library is free software; you can redistribute it and/or
>>>> + * modify it under the terms of the GNU Lesser General Public
>>>> + * License as published by the Free Software Foundation; either
>>>> + * version 2 of the License, or (at your option) any later version.
>>>> + *
>>>> + * This library is distributed in the hope that it will be useful,
>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>>> + * Lesser General Public License for more details.
>>>> + *
>>>> + * Contributions after 2012-10-29 are licensed under the terms of the
>>>> + * GNU GPL, version 2 or (at your option) any later version.
>>>
>>> Slightly off-topic to your patch, but since you're at it anyway: AFAIK
>>> the above sentence effectively means that we should update the copyright
>>> boiler plate to GPL2+ nowadays. See
>>> https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html section 3.
>>
>> (not a license expert)
>>
>> Do you want me to replace it also in cpu.h?
> 
> No, at least not directly here in this patch series. I think that's
> something for a separate patch (we've got the same issue in cpu.c and
> kvm.c), so just use the correct boilerplate text in internal.h here.
> 

I'll use the following:

/*
 * s390x internal definitions and helpers
 *
 * Copyright (c) 2009 Ulrich Hecht
 *
 * This work is licensed under the terms of the GNU LGPL, version 2.1 or
later.
 * See the COPYING.LIB file in the top-level directory.
 */


-- 

Thanks,

David