[Qemu-devel] [PATCH RFC 0/5] target/s390x: introduce internal.h and cleanup cpu.h

[David Hildenbrand]

cpu.h is accessed outside of target/s390x. It should only contain
what is expected to be accessed outside of this folder. Therefore, create
internal.h and move a lot to that file.

While doing that, I noticed that a lot of function prototypes not
available with CONFIG_USER_ONLY are not protected by CONFIG_USER_ONLY.

As these CONFIG_USER_ONLY are in general ugly, I decided to minimize
them to the bare minimum :]. Do we care? I dropped it wherever possible.

My compiler doesn't bail out, so let's see what the bot says.

There is still a lot to clean up (e.g. do we want kvm-stub.c ?). This is
the first step.

David Hildenbrand (5):
  target/s390x: introduce internal.h
  target/s390x: move a couple of functions to cpu.c
  s390x: avoid calling kvm_ functions outside of target/s390x/
  target/s390x: remove all CONFIG_KVM from cpu.h
  target/s390x: cleanup cpu.h

 hw/s390x/s390-virtio-ccw.c |   4 +-
 target/s390x/arch_dump.c   |   1 +
 target/s390x/cc_helper.c   |   1 +
 target/s390x/cpu.c         |  87 ++++++
 target/s390x/cpu.h         | 759 +++++----------------------------------------
 target/s390x/cpu_models.c  |   1 +
 target/s390x/diag.c        |   1 +
 target/s390x/excp_helper.c |   1 +
 target/s390x/fpu_helper.c  |   1 +
 target/s390x/gdbstub.c     |   1 +
 target/s390x/helper.c      |   1 +
 target/s390x/int_helper.c  |   1 +
 target/s390x/internal.h    | 612 ++++++++++++++++++++++++++++++++++++
 target/s390x/interrupt.c   |   1 +
 target/s390x/ioinst.c      |   1 +
 target/s390x/kvm.c         |   1 +
 target/s390x/machine.c     |   1 +
 target/s390x/mem_helper.c  |   1 +
 target/s390x/misc_helper.c |   1 +
 target/s390x/mmu_helper.c  |   1 +
 target/s390x/translate.c   |   1 +
 21 files changed, 787 insertions(+), 692 deletions(-)
 create mode 100644 target/s390x/internal.h

-- 
2.9.4