Re: [Qemu-devel] [PATCH v3 8/8] error: Add a 'error: ' prefix to error_report()

[Alistair Francis]

On Tue, Jul 11, 2017 at 7:44 PM, Max Reitz <address@hidden> wrote:
> On 2017-07-11 14:07, Alistair Francis wrote:
>> As we don't regard error messages as a stable API the let's add a
>> 'error: ' prefix to the original error_report() messages.
>>
>> Signed-off-by: Alistair Francis <address@hidden>
>> ---
>>
>>  util/qemu-error.c | 1 +
>>  1 file changed, 1 insertion(+)
>
> This breaks quite a few qemu-iotests.

Hmmm... Ok, I'll have to dig into that.

I'm traveling at the moment so I won't get a chance to fix this. I'm
going to send the next version of this series, but remove this patch
and I can look at adding it again when I get back. There is already a
few things that have been pointed out that need to be fixed after this
patch set.

Do people think we should add this prefix or leave the error messages
as is? I haven't heard a definitive answer if people think this is the
right path to take.

Thanks,
Alistair

>
> Max
>