Re: [Qemu-devel] [PATCH v3 0/8] Implement a warning_report function

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v3 0/8]  Implement a warning_report function
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
60686e6 error: Add a 'error: ' prefix to error_report()
5364f27 Convert error_report*_err() to warn_report*_err()
a893104 error: Implement the warn and free Error functions
acb3d0e char-socket: Report TCP socket waiting as information
49d68cd hw/i386: Improve some of the warning messages
ec1a246 Convert error_report() to warn_report()
23f4974 error: Functions to report warnings and informational messages
fdc3c8a util/qemu-error: Rename error_print_loc() to be more generic

=== OUTPUT BEGIN ===
Checking PATCH 1/8: util/qemu-error: Rename error_print_loc() to be more 
generic...
Checking PATCH 2/8: error: Functions to report warnings and informational 
messages...
Checking PATCH 3/8: Convert error_report() to warn_report()...
ERROR: line over 90 characters
#694: FILE: tests/test-qdev-global-props.c:235:
+    g_test_trap_assert_stderr("*warning: global dynamic-prop-type-bad.prop3 
has invalid class name\n*");

WARNING: line over 80 characters
#698: FILE: tests/test-qdev-global-props.c:237:
+    g_test_trap_assert_stderr("*warning: global nohotplug-type.prop5=105 not 
used\n*");

ERROR: line over 90 characters
#699: FILE: tests/test-qdev-global-props.c:238:
+    g_test_trap_assert_stderr("*warning: global nondevice-type.prop6 has 
invalid class name\n*");

total: 2 errors, 1 warnings, 539 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/8: hw/i386: Improve some of the warning messages...
Checking PATCH 5/8: char-socket: Report TCP socket waiting as information...
Checking PATCH 6/8: error: Implement the warn and free Error functions...
Checking PATCH 7/8: Convert error_report*_err() to warn_report*_err()...
Checking PATCH 8/8: error: Add a 'error: ' prefix to error_report()...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden