[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command |
Date: |
Tue, 06 Jun 2017 18:19:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 05/06/2017 14:24, Eric Blake wrote:
>> On 06/05/2017 03:52 AM, Stefan Fritsch wrote:
>>> Sending a break on a serial console can be useful for debugging the
>>> guest. But not all chardev backends support sending breaks (only telnet
>>> and mux do). The chardev-send-break command allows to send a break even
>>> if using other backends.
>>>
>>> Signed-off-by: Stefan Fritsch <address@hidden>
>>> ---
>>> chardev/char.c | 12 ++++++++++++
>>> hmp-commands.hx | 16 ++++++++++++++++
>>> hmp.c | 8 ++++++++
>>> hmp.h | 1 +
>>> qapi-schema.json | 20 ++++++++++++++++++++
>>> 5 files changed, 57 insertions(+)
>>
>> Is there an obvious test that we can enhance to add coverage of the new
>> QMP command?
>
> You could have a new test covering hw/char/serial.c, but I wouldn't let
> that hold the patch.
Holding patches is pretty much the only leverage I have to get tests for
new stuff :)
Asking for tests that cover all of serial.c wouldn't be fair. But I am
asking for basic test coverage of new QMP commands.
Message-ID: <address@hidden>
https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg00296.html
Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command, Dr. David Alan Gilbert, 2017/06/08