Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

[Paolo Bonzini]

> >> Is there an obvious test that we can enhance to add coverage of the new
> >> QMP command?
> >
> > You could have a new test covering hw/char/serial.c, but I wouldn't let
> > that hold the patch.
> 
> Holding patches is pretty much the only leverage I have to get tests for
> new stuff :)
> 
> Asking for tests that cover all of serial.c wouldn't be fair.  But I am
> asking for basic test coverage of new QMP commands.

I agree, on the other hand it's not exactly a comparable area.  I am planning
to write a serial qtest for migration as well (which is more complex than this
QMP command) so I might as well write the test for this new QMP command myself
to get my feet wet...

Paolo