Re: [Qemu-devel] [PATCH 4/4] x86: Support feature=force on the command-line

[Eduardo Habkost]

On Tue, May 02, 2017 at 04:42:02PM -0500, Eric Blake wrote:
[...]
> > -    if (value) {
> > -        cpu->env.features[fp->w] |= fp->mask;
> > -    } else {
> > -        cpu->env.features[fp->w] &= ~fp->mask;
> > +    switch (value->type) {
> > +    case QTYPE_QBOOL:
> > +        if (value->u.q_bool) {
> > +            cpu->env.features[fp->w] |= fp->mask;
> > +        } else {
> > +            cpu->env.features[fp->w] &= ~fp->mask;
> > +        }
> > +        cpu->env.forced_features[fp->w] &= ~fp->mask;
> > +        cpu->env.user_features[fp->w] |= fp->mask;
> > +    break;
> 
> Isn't the break supposed to be indented four more spaces?
> 
[...]

I will fix it in v2. Thanks!

-- 
Eduardo